51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
78 lines
2.7 KiB
Plaintext
78 lines
2.7 KiB
Plaintext
Operating systems have global directories where any user has write access. Those folders are mostly used as temporary storage areas like ``++/tmp++`` in Linux based systems. An application manipulating files from these folders is exposed to race conditions on filenames: a malicious user can try to create a file with a predictable name before the application does. A successful attack can result in other files being accessed, modified, corrupted or deleted. This risk is even higher if the application runs with elevated permissions.
|
|
|
|
|
|
In the past, it has led to the following vulnerabilities:
|
|
|
|
* https://nvd.nist.gov/vuln/detail/CVE-2012-2451[CVE-2012-2451]
|
|
* https://nvd.nist.gov/vuln/detail/CVE-2015-1838[CVE-2015-1838]
|
|
|
|
This rule raises an issue whenever it detects a hard-coded path to a publicly writable directory like ``++/tmp++`` (see examples bellow). It also detects access to environment variables that point to publicly writable directories, e.g., ``++TMP++``, ``++TMPDIR++`` and ``++TEMP++``.
|
|
|
|
* ``++/tmp++``
|
|
* ``++/var/tmp++``
|
|
* ``++/usr/tmp++``
|
|
* ``++/dev/shm++``
|
|
* ``++/dev/mqueue++``
|
|
* ``++/run/lock++``
|
|
* ``++/var/run/lock++``
|
|
* ``++/Library/Caches++``
|
|
* ``++/Users/Shared++``
|
|
* ``++/private/tmp++``
|
|
* ``++/private/var/tmp++``
|
|
* ``++\Windows\Temp++``
|
|
* ``++\Temp++``
|
|
* ``++\TMP++``
|
|
* ``++%USERPROFILE%\AppData\Local\Temp++``
|
|
|
|
include::../ask-yourself.adoc[]
|
|
|
|
== Recommended Secure Coding Practices
|
|
|
|
Out of the box, .NET is missing secure-by-design APIs to create temporary files. To overcome this, one of the following options can be used:
|
|
|
|
* Use a dedicated sub-folder with tightly controlled permissions
|
|
* Created temporary files in a publicly writable folder and make sure:
|
|
** Generated filename is unpredictable
|
|
** File is readable and writable only by the creating user ID
|
|
** File descriptor is not inherited by child processes
|
|
** File is destroyed as soon as it is closed
|
|
|
|
== Sensitive Code Example
|
|
|
|
----
|
|
using var writer = new StreamWriter("/tmp/f"); // Sensitive
|
|
----
|
|
|
|
----
|
|
var tmp = Environment.GetEnvironmentVariable("TMP"); // Sensitive
|
|
----
|
|
|
|
== Compliant Solution
|
|
|
|
[source,csharp]
|
|
----
|
|
var randomPath = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
|
|
|
|
// Creates a new file with write, non inheritable permissions which is deleted on close.
|
|
using var fileStream = new FileStream(randomPath, FileMode.CreateNew, FileAccess.Write, FileShare.None, 4096, FileOptions.DeleteOnClose);
|
|
using var writer = new StreamWriter(fileStream);
|
|
----
|
|
|
|
include::../see.adoc[]
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|