rspec/rules/S6553/python/rule.adoc
Fred Tingaud 16f6c0aecf
Inline adoc when include has no additional value (#1940)
Inline adoc files when they are included exactly once.

Also fix language tags because this inlining gives us better information
on what language the code is written in.
2023-05-25 14:18:12 +02:00

52 lines
2.0 KiB
Plaintext

This rule suggests avoiding the use of "null=True" on string-based fields such as CharField and TextField in Django models. Instead, it recommends using blank=True, which allows an empty string as a valid value while still maintaining the ability to query and filter on the field.
== Why is this an issue?
Using "null=True" on string-based fields can lead to inconsistent and unexpected behavior. In Django, "null=True" allows the field to have a NULL value in the database. However, the Django convention to represent the absence of data for a string is an empty string. Having two ways to represent the absence of data can cause problems when querying and filtering on the field. For example, if a CharField with "null=True" has a value of NULL in the database, querying for an empty string will not return that object.
== How to fix it
Instead of using "null=True", use "blank=True" on string-based fields such as CharField and TextField. This allows an empty string as a valid value while still maintaining the ability to query and filter on the field. If a field should not be left empty, specify a default value using the default argument.
=== Code examples
==== Noncompliant code example
[source,python]
----
class ExampleModel(models.Model):
name = models.CharField(max_length=50, null=True)
----
==== Compliant solution
[source,python]
----
class ExampleModel(models.Model):
name = models.CharField(max_length=50, blank=True)
----
== Exceptions
If `unique=True` and `blank=True` are both set, `null=True` is required to avoid unique constraint violations when saving multiple objects with blank values. No issue will be raised in this scenario.
== Resources
=== Documentation
https://docs.djangoproject.com/en/4.1/ref/models/fields[Django model field reference]
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
If "blank=True" is not set:
Replace this "null=True" flag with "blank=True".
If "blank=True" is set:
Remove this "null=True" flag.
'''
endif::env-github,rspecator-view[]