51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
56 lines
1.4 KiB
Plaintext
56 lines
1.4 KiB
Plaintext
include::../description.adoc[]
|
|
|
|
include::../ask-yourself.adoc[]
|
|
|
|
include::../recommended.adoc[]
|
|
|
|
== Sensitive Code Example
|
|
|
|
----
|
|
Public Sub SqlCommands(ByVal connection As SqlConnection, ByVal query As String, ByVal param As String)
|
|
Dim sensitiveQuery As String = String.Concat(query, param)
|
|
command = New SqlCommand(sensitiveQuery) ' Sensitive
|
|
|
|
command.CommandText = sensitiveQuery ' Sensitive
|
|
|
|
Dim adapter As SqlDataAdapter
|
|
adapter = New SqlDataAdapter(sensitiveQuery, connection) ' Sensitive
|
|
End Sub
|
|
|
|
Public Sub Foo(ByVal context As DbContext, ByVal query As String, ByVal param As String)
|
|
Dim sensitiveQuery As String = String.Concat(query, param)
|
|
context.Database.ExecuteSqlCommand(sensitiveQuery) ' Sensitive
|
|
|
|
context.Query(Of User)().FromSql(sensitiveQuery) ' Sensitive
|
|
End Sub
|
|
----
|
|
|
|
== Compliant Solution
|
|
|
|
[source,vbnet]
|
|
----
|
|
Public Sub Foo(ByVal context As DbContext, ByVal value As String)
|
|
context.Database.ExecuteSqlCommand("SELECT * FROM mytable WHERE mycol=@p0", value) ' Compliant, the query is parameterized
|
|
End Sub
|
|
----
|
|
|
|
include::../see.adoc[]
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
include::../highlighting.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|