rspec/rules/S2234/php/rule.adoc
Fred Tingaud 51369b610e
Make sure that includes are always surrounded by empty lines (#2270)
When an include is not surrounded by empty lines, its content is inlined
on the same line as the adjacent content. That can lead to broken tags
and other display issues.
This PR fixes all such includes and introduces a validation step that
forbids introducing the same problem again.
2023-06-22 10:38:01 +02:00

55 lines
930 B
Plaintext
Raw Blame History

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

== Why is this an issue?
include::../description.adoc[]
=== Noncompliant code example
[source,php]
----
public function divide($divisor, $dividend) {
return $divisor/$dividend;
}
public function doTheThing() {
$divisor = 15;
$dividend = 5;
$result = $this->divide($dividend, $divisor); // Noncompliant; operation succeeds, but result is unexpected
}
----
=== Compliant solution
[source,php]
----
public function divide($divisor, $dividend) {
return $divisor/$dividend;
}
public function doTheThing() {
$divisor = 15;
$dividend = 5;
$result = $this->divide($divisor, $dividend); // Compliant
}{code}
h4.  
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]