95ce8c6119
Improvement identified in #2790. Add a prefix to the diff-id when it is used multiple times in different "how to fix it in XYZ" sections to avoid ambiguity and pedantically follow the spec: > A single and unique diff-id should be used only once for each type of code example as shown in the description of a rule. Obvious typos around `diff-type` were fixed.
40 lines
929 B
Plaintext
40 lines
929 B
Plaintext
== How to fix it in Mongoose
|
|
|
|
=== Code examples
|
|
|
|
include::../../common/fix/code-rationale.adoc[]
|
|
|
|
==== Noncompliant code example
|
|
|
|
[source,javascript,diff-id=11,diff-type=noncompliant]
|
|
----
|
|
const mongoose = require('mongoose');
|
|
|
|
function(req, res) {
|
|
let query = { user: req.query.user, city: req.query.city };
|
|
const userModel = mongoose.model('User', userSchema);
|
|
userModel.find(query, (err, users) => {}); // Noncompliant
|
|
}
|
|
----
|
|
|
|
==== Compliant solution
|
|
|
|
[source,javascript,diff-id=11,diff-type=compliant]
|
|
----
|
|
const mongoose = require('mongoose');
|
|
|
|
function (req, res) {
|
|
let query = { user: req.query.user.toString(), city: req.query.city.toString() };
|
|
const userModel = mongoose.model('User', userSchema);
|
|
userModel.find(query, (err, users) => {});
|
|
}
|
|
----
|
|
|
|
=== How does this work?
|
|
|
|
include::../../common/fix/plain-string-values.adoc[]
|
|
|
|
=== Pitfalls
|
|
|
|
include::../../common/pitfalls/code-execution.adoc[]
|