
The main changes are: * Split RuleCreator: move some of its content to RspecRepo and to RuleEditor in new modules. * Refactor tests accordingly. Other less important changes: * Sort and remove unnecessary imports * Remove unimplemented functions and unnecessary classes * Make some functions private * Move pushd from utils to tests where it is only used * Reduce code duplication here and there * Remove unnecessary Mock in some tests * Improve coverage for add_language_to_rule
25 lines
885 B
Python
25 lines
885 B
Python
from pathlib import Path
|
|
|
|
from rspec_tools.rules import RulesRepository
|
|
|
|
def test_list_rules(mockrules: Path):
|
|
'''Check that rules are all listed.'''
|
|
rules = {rule.id for rule in RulesRepository(rules_path=mockrules).rules}
|
|
assert rules == {'S100', 'S120', 'S4727', 'S1033'}
|
|
|
|
|
|
def test_list_languages(mockrules: Path):
|
|
'''Check that languages are all listed.'''
|
|
rule = RulesRepository(rules_path=mockrules).get_rule('S120')
|
|
languages = {lang.language for lang in rule.specializations}
|
|
assert languages == {'flex', 'java', 'plsql'}
|
|
|
|
|
|
def test_get_metadata(mockrules: Path):
|
|
'''Check that language metadata are correctly overriden.'''
|
|
rule = RulesRepository(rules_path=mockrules).get_rule('S120')
|
|
plsql = rule.get_language('plsql')
|
|
assert plsql.metadata['sqKey'] == 'PlSql.PackageNaming'
|
|
java = rule.get_language('java')
|
|
assert java.metadata['sqKey'] == 'S120'
|