51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
85 lines
1.4 KiB
Plaintext
85 lines
1.4 KiB
Plaintext
include::../description.adoc[]
|
|
|
|
include::../ask-yourself.adoc[]
|
|
|
|
include::../recommended.adoc[]
|
|
|
|
== Sensitive Code Example
|
|
|
|
----
|
|
chmod("foo", 0777); // Sensitive
|
|
----
|
|
|
|
----
|
|
umask(0); // Sensitive
|
|
umask(0750); // Sensitive
|
|
----
|
|
|
|
For https://symfony.com/doc/current/components/filesystem.html[Symfony Filesystem]:
|
|
|
|
----
|
|
use Symfony\Component\Filesystem\Filesystem;
|
|
|
|
$fs = new Filesystem();
|
|
$fs->chmod("foo", 0777); // Sensitive
|
|
----
|
|
|
|
For https://laravel.com/api/8.x/Illuminate/Filesystem/Filesystem.html[Laravel Filesystem]:
|
|
|
|
----
|
|
use Illuminate\Filesystem\Filesystem;
|
|
|
|
$fs = new Filesystem();
|
|
$fs->chmod("foo", 0777); // Sensitive
|
|
----
|
|
|
|
== Compliant Solution
|
|
|
|
[source,php]
|
|
----
|
|
chmod("foo", 0750); // Compliant
|
|
----
|
|
|
|
[source,php]
|
|
----
|
|
umask(0027); // Compliant
|
|
----
|
|
|
|
For https://symfony.com/doc/current/components/filesystem.html[Symfony Filesystem]:
|
|
|
|
[source,php]
|
|
----
|
|
use Symfony\Component\Filesystem\Filesystem;
|
|
|
|
$fs = new Filesystem();
|
|
$fs->chmod("foo", 0750); // Compliant
|
|
----
|
|
|
|
For https://laravel.com/api/8.x/Illuminate/Filesystem/Filesystem.html[Laravel Filesystem]:
|
|
|
|
[source,php]
|
|
----
|
|
use Illuminate\Filesystem\Filesystem;
|
|
|
|
$fs = new Filesystem();
|
|
$fs->chmod("foo", 0750); // Compliant
|
|
----
|
|
|
|
include::../see.adoc[]
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|