51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
48 lines
1.1 KiB
Plaintext
48 lines
1.1 KiB
Plaintext
include::../description.adoc[]
|
|
|
|
include::../ask-yourself.adoc[]
|
|
|
|
== Recommended Secure Coding Practices
|
|
|
|
* Use an email library which sanitizes headers (java.mail >= 1.5.6).
|
|
* Use html escape functions to sanitize every piece of data used to in the email body.
|
|
* Verify application logic to make sure that email base feature can not be abuse to:
|
|
** Send arbitrary email for spamming or fishing
|
|
** Disclose sensitive email content
|
|
|
|
== Sensitive Code Example
|
|
|
|
----
|
|
import javax.mail.*;
|
|
import javax.mail.internet.MimeMessage;
|
|
|
|
public class Main {
|
|
public static void sendEmail (Session session, String subject) throws MessagingException{
|
|
Message message = new MimeMessage(session); // Sensitive
|
|
|
|
// For example the setSubject method is vulnerable to Header injection before
|
|
// version 1.5.6 of javamail
|
|
message.setSubject(subject);
|
|
// ...
|
|
}
|
|
}
|
|
----
|
|
|
|
include::../see.adoc[]
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|