51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
56 lines
842 B
Plaintext
56 lines
842 B
Plaintext
== Why is this an issue?
|
|
|
|
Return of boolean literal statements wrapped into ``++if-then-else++`` flow should be simplified.
|
|
|
|
|
|
Note that if the result of the expression is not a boolean but for instance an integer, then double negation should be used for proper conversion.
|
|
|
|
[source,javascript]
|
|
----
|
|
if (expression) {
|
|
return true;
|
|
} else {
|
|
return false;
|
|
}
|
|
----
|
|
|
|
or
|
|
|
|
[source,javascript]
|
|
----
|
|
if (expression) {
|
|
return true;
|
|
}
|
|
return false;
|
|
----
|
|
|
|
|
|
=== Compliant solution
|
|
|
|
[source,javascript]
|
|
----
|
|
return expression;
|
|
----
|
|
or
|
|
|
|
[source,javascript]
|
|
----
|
|
return !!expression;
|
|
----
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|