rspec/rules/S2589/comments-and-links.adoc
nicolas-gauthier-sonarsource ab6d0f08b7
Modify S2589: Migrate to LaYC (#3297)
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
2023-10-18 14:26:59 +02:00

12 lines
780 B
Plaintext

=== deprecates: S1850
=== is related to: S3650
=== relates to: S1764
=== on 1 Feb 2016, 10:21:45 Freddy Mallet wrote:
Question : should we consider this RSPEC as being fully a subset of RSPEC-2583 ? I think the only motivation behind this split was to use a different severity and this remains a relevant point.
=== on 29 Feb 2016, 08:37:04 Pierre-Yves Nicolas wrote:
\[~freddy.mallet] I don't really see why this RSPEC is "fully a subset of RSPEC-2583". Maybe that makes sense if it is implemented through symbolic execution with short-circuit logical operators, but then it all depends on the order of sub-conditions. Please consider ``++IF X > 1 AND X = 5++``: I think that this code would raise an issue for the current description of this RSPEC, but not for RSPEC-2583.