rspec/rules/S2955/csharp/rule.adoc
2022-02-04 16:28:24 +00:00

61 lines
1.2 KiB
Plaintext

When constraints have not been applied to restrict a generic type parameter to be a reference type, then a value type, such as a ``++struct++``, could also be passed. In such cases, comparing the type parameter to ``++null++`` would always be false, because a ``++struct++`` can be empty, but never ``++null++``. If a value type is truly what's expected, then the comparison should use ``++default()++``. If it's not, then constraints should be added so that no value type can be passed.
== Noncompliant Code Example
[source,csharp]
----
private bool IsDefault<T>(T value)
{
if (value == null) // Noncompliant
{
// ...
}
// ...
}
----
== Compliant Solution
[source,csharp]
----
private bool IsDefault<T>(T value)
{
if(object.Equals(value, default(T)))
{
// ...
}
// ...
}
----
or
[source,csharp]
----
private bool IsDefault<T>(T value) where T : class
{
if (value == null)
{
// ...
}
// ...
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::comments-and-links.adoc[]
endif::env-github,rspecator-view[]