39 lines
795 B
Plaintext
39 lines
795 B
Plaintext
Return of boolean literal statements wrapped into ``++if-then-else++`` ones should be simplified.
|
|
|
|
Similarly, method invocations wrapped into ``++if-then-else++`` differing only from boolean literals should be simplified into a single invocation.
|
|
|
|
== Noncompliant Code Example
|
|
|
|
----
|
|
boolean foo(Object param) {
|
|
if (expression) { // Noncompliant
|
|
bar(param, true, "qix");
|
|
} else {
|
|
bar(param, false, "qix");
|
|
}
|
|
|
|
if (expression) { // Noncompliant
|
|
return true;
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
----
|
|
|
|
== Compliant Solution
|
|
|
|
----
|
|
boolean foo(Object param) {
|
|
bar(param, expression, "qix");
|
|
|
|
return expression;
|
|
}
|
|
----
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
endif::env-github,rspecator-view[]
|