rspec/rules/S2041/php/rule.adoc
Fred Tingaud 16f6c0aecf
Inline adoc when include has no additional value (#1940)
Inline adoc files when they are included exactly once.

Also fix language tags because this inlining gives us better information
on what language the code is written in.
2023-05-25 14:18:12 +02:00

58 lines
1.2 KiB
Plaintext

== Why is this an issue?
``++echo++`` can be called with or without parentheses, but it is best practice to leave parentheses off the call because using parentheses with multiple arguments will result in a parse error.
=== Noncompliant code example
[source,php]
----
echo("Hello"); // Noncompliant, but it works
echo("Hello", "World"); // Noncompliant. Parse error
----
=== Compliant solution
[source,php]
----
echo "Hello";
echo "Hello","World!";
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Remove the parentheses from this "echo" call.
'''
== Comments And Links
(visible only on this page)
=== on 9 Oct 2014, 18:24:33 Ann Campbell wrote:
\[~linda.martin] please review the updated description
=== on 10 Oct 2014, 07:24:45 Linda Martin wrote:
\[~ann.campbell.2] Perfect for me!
=== on 10 Oct 2014, 09:49:07 Freddy Mallet wrote:
@Ann, for me the "Compliant Solution" is misleading. I would replace it by :
----
echo "Hello";
echo "Hello", "World!"
----
=== on 10 Oct 2014, 11:49:28 Ann Campbell wrote:
Yes, [~freddy.mallet], thanks. I'm not assigning this one to you since you've apparently already reviewed it. :-)
endif::env-github,rspecator-view[]