51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
59 lines
1.4 KiB
Plaintext
59 lines
1.4 KiB
Plaintext
include::../description.adoc[]
|
|
|
|
include::../ask-yourself.adoc[]
|
|
|
|
include::../recommended.adoc[]
|
|
|
|
== Sensitive Code Example
|
|
|
|
----
|
|
new File("/tmp/myfile.txt"); // Sensitive
|
|
Paths.get("/tmp/myfile.txt"); // Sensitive
|
|
|
|
java.io.File.createTempFile("prefix", "suffix"); // Sensitive, will be in the default temporary-file directory.
|
|
java.nio.file.Files.createTempDirectory("prefix"); // Sensitive, will be in the default temporary-file directory.
|
|
----
|
|
|
|
----
|
|
Map<String, String> env = System.getenv();
|
|
env.get("TMP"); // Sensitive
|
|
----
|
|
|
|
== Compliant Solution
|
|
|
|
[source,java]
|
|
----
|
|
new File("/myDirectory/myfile.txt"); // Compliant
|
|
|
|
File.createTempFile("prefix", "suffix", new File("/mySecureDirectory")); // Compliant
|
|
|
|
if(SystemUtils.IS_OS_UNIX) {
|
|
FileAttribute<Set<PosixFilePermission>> attr = PosixFilePermissions.asFileAttribute(PosixFilePermissions.fromString("rwx------"));
|
|
Files.createTempFile("prefix", "suffix", attr); // Compliant
|
|
}
|
|
else {
|
|
File f = Files.createTempFile("prefix", "suffix").toFile(); // Compliant
|
|
f.setReadable(true, true);
|
|
f.setWritable(true, true);
|
|
f.setExecutable(true, true);
|
|
}
|
|
----
|
|
|
|
include::../see.adoc[]
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|