
Inline adoc files when they are included exactly once. Also fix language tags because this inlining gives us better information on what language the code is written in.
53 lines
987 B
Plaintext
53 lines
987 B
Plaintext
== Why is this an issue?
|
|
|
|
Assertions comparing an object to itself are more likely to be bugs due to developer's carelessness.
|
|
|
|
|
|
This rule raises an issue when the actual expression matches the expected expression.
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,php]
|
|
----
|
|
assertEqual($a, $a); // Noncompliant
|
|
assertSame($a, $a); // Noncompliant
|
|
assertNotEqual($a, $a); // Noncompliant
|
|
assertNotSame($a, $a); // Noncompliant
|
|
----
|
|
|
|
=== Compliant solution
|
|
|
|
[source,php]
|
|
----
|
|
assertEqual($expected, $a);
|
|
assertSame($expected, $a);
|
|
assertNotEqual($expected, $a);
|
|
assertNotSame($expected, $a);
|
|
----
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
=== Message
|
|
|
|
Replace this assertion to not have the same actual and expected expression.
|
|
|
|
|
|
=== Highlighting
|
|
|
|
Primary: expected expression
|
|
|
|
|
|
Secondary: actual expression
|
|
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
endif::env-github,rspecator-view[]
|