29 lines
1.6 KiB
Plaintext
29 lines
1.6 KiB
Plaintext
=== relates to: S2536
|
|
|
|
=== on 17 Sep 2014, 10:38:27 Freddy Mallet wrote:
|
|
@Ann, I would have associated this rule to the "Reliability" SQALE characteristic. I'm using the "Changeability - Data related changeability" mainly when a design flaw may prevent the developer from changing a structure of data.
|
|
|
|
=== on 8 Oct 2014, 15:46:04 Ann Campbell wrote:
|
|
This rule should be only about the use of the global keyword. Instead of grabbing value from global scope, fcn should receive it as a parameter
|
|
|
|
=== on 8 Oct 2014, 16:23:30 Ann Campbell wrote:
|
|
\[~linda.martin], see what you think about the rewrite. Also, I'm not sure brain-overload still applies...? convention?
|
|
|
|
=== on 9 Oct 2014, 07:27:49 Linda Martin wrote:
|
|
\[~ann.campbell.2]
|
|
|
|
. I just have a small suggestion for the description, WDYT about something like:
|
|
"_{color:grey}Global variables are a useful construct, but they should not be abused{color}_.
|
|
A function can access the global scope through the global keyword.This practice considerably reduces the readability of a function. The global variable should be passed as a parameter of the function."
|
|
. About the tag I agree, convention suits well for me.
|
|
. Also, maybe we could the add in this rule the use of $GLOBALS array, see: \http://jira.codehaus.org/browse/SONARPHP-131, sorry for realising this only now.
|
|
|
|
|
|
|
|
=== on 9 Oct 2014, 14:19:12 Ann Campbell wrote:
|
|
\[~linda.martin] all 3 suggestions taken, but you'll want to double-check my syntax/usage of $GLOBALS in the noncompliant example.
|
|
|
|
=== on 23 Oct 2014, 08:02:54 Linda Martin wrote:
|
|
\[~ann.campbell.2] Thanks! Perfect for me.
|
|
|