6f24cc0632
In some cases, the `rule.adoc` at root of a rule is never included anywhere and thus is dead code. It's a maintenance cost by itself, but also it misses opportunities to inline code that seems used by two documents when in fact only one document is actually rendered. And this missed opportunity, in turn, stops us from applying the correct language tag on the code samples.
65 lines
1.2 KiB
Plaintext
65 lines
1.2 KiB
Plaintext
== Why is this an issue?
|
|
|
|
include::../description.adoc[]
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,javascript]
|
|
----
|
|
for (var i = 1; i != 10; i += 2) // Noncompliant. Infinite; i goes from 9 straight to 11.
|
|
{
|
|
//...
|
|
}
|
|
----
|
|
|
|
=== Compliant solution
|
|
|
|
[source,javascript]
|
|
----
|
|
for (var i = 1; i <= 10; i += 2) // Compliant
|
|
{
|
|
//...
|
|
}
|
|
----
|
|
|
|
=== Exceptions
|
|
|
|
Equality operators are ignored if the loop counter is not modified within the body of the loop and either:
|
|
|
|
* starts below the ending value and is incremented by 1 on each iteration.
|
|
* starts above the ending value and is decremented by 1 on each iteration.
|
|
|
|
Equality operators are also ignored when the test is against ``++null++``.
|
|
|
|
[source,javascript]
|
|
----
|
|
for (var i = 0; arr[i] != null; i++) {
|
|
// ...
|
|
}
|
|
|
|
for (var i = 0; (item = arr[i]) != null; i++) {
|
|
// ...
|
|
}
|
|
----
|
|
|
|
== Resources
|
|
|
|
* https://cwe.mitre.org/data/definitions/835[MITRE, CWE-835] - Loop with Unreachable Exit Condition ('Infinite Loop')
|
|
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|