51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
51 lines
1.1 KiB
Plaintext
51 lines
1.1 KiB
Plaintext
include::../description.adoc[]
|
|
|
|
include::../ask-yourself.adoc[]
|
|
|
|
include::../recommended.adoc[]
|
|
|
|
== Sensitive Code Example
|
|
|
|
In Express.js application the code is sensitive if the https://www.npmjs.com/package/helmet[helmet] or https://www.npmjs.com/package/hsts[hsts] middleware are disabled or used without recommended values:
|
|
|
|
----
|
|
const express = require('express');
|
|
const helmet = require('helmet');
|
|
|
|
let app = express();
|
|
|
|
app.use(helmet.hsts({
|
|
maxAge: 3153600, // Sensitive, recommended >= 15552000
|
|
includeSubDomains: false // Sensitive, recommended 'true'
|
|
}));
|
|
----
|
|
|
|
== Compliant Solution
|
|
|
|
In Express.js application a standard way to implement HSTS is with the https://www.npmjs.com/package/helmet[helmet] or https://www.npmjs.com/package/hsts[hsts] middleware:
|
|
|
|
[source,javascript]
|
|
----
|
|
const express = require('express');
|
|
const helmet = require('helmet');
|
|
|
|
let app = express();
|
|
|
|
app.use(helmet.hsts({
|
|
maxAge: 31536000,
|
|
includeSubDomains: true
|
|
})); // Compliant
|
|
----
|
|
|
|
include::../see.adoc[]
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|