6550e65756
Improvement identified in #2790. Add a prefix to the diff-id when it is used multiple times in different "how to fix it in XYZ" sections to avoid ambiguity and pedantically follow the spec: > A single and unique diff-id should be used only once for each type of code example as shown in the description of a rule. Obvious typos around `diff-type` were fixed.
40 lines
863 B
Plaintext
40 lines
863 B
Plaintext
== How to fix it in Laravel
|
|
|
|
=== Code examples
|
|
|
|
include::../../common/fix/code-rationale.adoc[]
|
|
|
|
==== Noncompliant code example
|
|
|
|
[source,php,diff-id=11,diff-type=noncompliant]
|
|
----
|
|
use Illuminate\Http\Request;
|
|
use Illuminate\Support\Facades\Cookie;
|
|
|
|
Route::get("/checkcookie", function (Request $request) {
|
|
if (!$request->hasCookie('PHPSESSID')) {
|
|
$value = $request->query->get('cookie');
|
|
Cookie::queue('PHPSESSID', $value, 86400); // Noncompliant
|
|
}
|
|
|
|
return view('welcome');
|
|
});
|
|
----
|
|
|
|
==== Compliant solution
|
|
|
|
[source,php,diff-id=11,diff-type=compliant]
|
|
----
|
|
use Illuminate\Http\Request;
|
|
|
|
Route::get("/checkcookie", function (Request $request) {
|
|
if (!$request->hasCookie('PHPSESSID')) {
|
|
return redirect()->route('getcookie');
|
|
}
|
|
|
|
return view('welcome');
|
|
});
|
|
----
|
|
|
|
include::../../common/fix/how-does-this-work.adoc[]
|