51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
102 lines
2.1 KiB
Plaintext
102 lines
2.1 KiB
Plaintext
include::../description.adoc[]
|
|
|
|
include::../ask-yourself.adoc[]
|
|
|
|
include::../recommended.adoc[]
|
|
|
|
== Sensitive Code Example
|
|
|
|
No secure policy is attached to this bucket:
|
|
|
|
----
|
|
resource "aws_s3_bucket" "mynoncompliantbucket" { # Sensitive
|
|
bucket = "mynoncompliantbucketname"
|
|
}
|
|
----
|
|
|
|
A policy is defined but forces only HTTPs communication for some users:
|
|
|
|
----
|
|
resource "aws_s3_bucket" "mynoncompliantbucket" { # Sensitive
|
|
bucket = "mynoncompliantbucketname"
|
|
}
|
|
|
|
resource "aws_s3_bucket_policy" "mynoncompliantbucketpolicy" {
|
|
bucket = "mynoncompliantbucketname"
|
|
|
|
policy = jsonencode({
|
|
Version = "2012-10-17"
|
|
Id = "mynoncompliantbucketpolicy"
|
|
Statement = [
|
|
{
|
|
Sid = "HTTPSOnly"
|
|
Effect = "Deny"
|
|
Principal = [
|
|
"arn:aws:iam::123456789123:root"
|
|
] # secondary location: only one principal is forced to use https
|
|
Action = "s3:*"
|
|
Resource = [
|
|
aws_s3_bucket.mynoncompliantbucketpolicy.arn,
|
|
"${aws_s3_bucket.mynoncompliantbucketpolicy.arn}/*",
|
|
]
|
|
Condition = {
|
|
Bool = {
|
|
"aws:SecureTransport" = "false"
|
|
}
|
|
}
|
|
},
|
|
]
|
|
})
|
|
}
|
|
----
|
|
|
|
== Compliant Solution
|
|
|
|
A secure policy that denies all HTTP requests is used:
|
|
|
|
[source,terraform]
|
|
----
|
|
resource "aws_s3_bucket" "mycompliantbucket" {
|
|
bucket = "mycompliantbucketname"
|
|
}
|
|
|
|
resource "aws_s3_bucket_policy" "mycompliantpolicy" {
|
|
bucket = "mycompliantbucketname"
|
|
|
|
policy = jsonencode({
|
|
Version = "2012-10-17"
|
|
Id = "mycompliantpolicy"
|
|
Statement = [
|
|
{
|
|
Sid = "HTTPSOnly"
|
|
Effect = "Deny"
|
|
Principal = "*"
|
|
Action = "s3:*"
|
|
Resource = [
|
|
aws_s3_bucket.mycompliantbucket.arn,
|
|
"${aws_s3_bucket.mycompliantbucket.arn}/*",
|
|
]
|
|
Condition = {
|
|
Bool = {
|
|
"aws:SecureTransport" = "false"
|
|
}
|
|
}
|
|
},
|
|
]
|
|
})
|
|
}
|
|
|
|
----
|
|
|
|
include::../see.adoc[]
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|