51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
52 lines
950 B
Plaintext
52 lines
950 B
Plaintext
== Why is this an issue?
|
|
|
|
Return of boolean literal statements wrapped into ``++if-then-else++`` ones should be simplified.
|
|
|
|
Similarly, method invocations wrapped into ``++if-then-else++`` differing only from boolean literals should be simplified into a single invocation.
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,java]
|
|
----
|
|
boolean foo(Object param) {
|
|
if (expression) { // Noncompliant
|
|
bar(param, true, "qix");
|
|
} else {
|
|
bar(param, false, "qix");
|
|
}
|
|
|
|
if (expression) { // Noncompliant
|
|
return true;
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
----
|
|
|
|
=== Compliant solution
|
|
|
|
[source,java]
|
|
----
|
|
boolean foo(Object param) {
|
|
bar(param, expression, "qix");
|
|
|
|
return expression;
|
|
}
|
|
----
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|