rspec/rules/S3026/java/rule.adoc
2021-04-28 18:08:03 +02:00

26 lines
561 B
Plaintext

There's no need to null-test a variable before an ``++instanceof++`` test because ``++instanceof++`` tests for ``++null++``. Similarly, there's no need to null-test a variable before dereferencing _some other_ object.
== Noncompliant Code Example
----
if (myVar != null && myVar instanceof MyClass) { // Noncompliant
// ...
} else if (myVar != null && myOtherVar.equals(myVar) { // Noncompliant
// ...
}
----
== Compliant Solution
----
if (myVar instanceof MyClass) {
// ...
} else if (myVar != null && myVar.equals(myOtherVar) {
// ...
}
----