51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
63 lines
981 B
Plaintext
63 lines
981 B
Plaintext
== Why is this an issue?
|
|
|
|
A ``++GOTO++`` statement is an unstructured change in the control flow. They should be avoided and replaced by structured constructs.
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,sql]
|
|
----
|
|
SET SERVEROUTPUT ON
|
|
|
|
DECLARE
|
|
i PLS_INTEGER := 42;
|
|
BEGIN
|
|
IF i < 0 THEN
|
|
GOTO negative; -- Noncompliant
|
|
END IF;
|
|
|
|
DBMS_OUTPUT.PUT_LINE('positive');
|
|
goto cleanup; -- Noncompliant
|
|
|
|
<<negative>>
|
|
DBMS_OUTPUT.PUT_LINE('negative!');
|
|
|
|
<<cleanup>>
|
|
NULL;
|
|
END;
|
|
/
|
|
----
|
|
|
|
=== Compliant solution
|
|
|
|
[source,sql]
|
|
----
|
|
SET SERVEROUTPUT ON
|
|
|
|
DECLARE
|
|
i PLS_INTEGER := 42;
|
|
BEGIN
|
|
IF i < 0 THEN
|
|
DBMS_OUTPUT.PUT_LINE('negative!'); -- Compliant
|
|
ELSE
|
|
DBMS_OUTPUT.PUT_LINE('positive');
|
|
END IF;
|
|
END;
|
|
/
|
|
----
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|