38 lines
1.3 KiB
Plaintext
38 lines
1.3 KiB
Plaintext
=== on 20 Aug 2013, 20:48:31 Freddy Mallet wrote:
|
|
Is implemented by \http://jira.codehaus.org/browse/SONARJAVA-313
|
|
|
|
=== on 21 Aug 2013, 00:10:32 Ann Campbell wrote:
|
|
This description says that in the case of a member name matching a method name, the member should be renamed. However, the non-compliant example shows a member that name-clashes with a private method.
|
|
|
|
|
|
In this case, I would be tempted to rename the method - particularly because it's private. Should the method in the examples be made public?
|
|
|
|
=== on 21 Aug 2013, 06:37:14 Freddy Mallet wrote:
|
|
Examples updated to make methods public
|
|
|
|
=== on 11 Oct 2013, 15:25:03 Dinesh Bolkensteyn wrote:
|
|
This rule is not valuable as it will trigger lots of violations on fluent APIs:
|
|
|
|
|
|
----
|
|
class ClassTree {
|
|
private final String name; // There really is no problem here
|
|
|
|
public String name() { // There really is no problem here
|
|
return name;
|
|
}
|
|
}
|
|
----
|
|
|
|
Class names and fields/method should never collide because of naming conventions. (although they might collide when compared case insensitively)
|
|
|
|
=== on 16 Jun 2014, 19:39:26 Ann Campbell wrote:
|
|
\[~freddy.mallet] You closed this RSpec "Won't Fix" last Friday, 2 minutes before you marked the implementing PHP ticket "manually tested"
|
|
|
|
|
|
Surely you closed this in error...?
|
|
|
|
=== on 16 Jun 2014, 19:40:26 Ann Campbell wrote:
|
|
\[~freddy.mallet] never mind.
|
|
|