44 lines
1.0 KiB
Plaintext
44 lines
1.0 KiB
Plaintext
There's no reason to use literal boolean values or nulls in assertions. Instead of using them with _assertEquals_, _assertNotEquals_ and similar methods, you should be using _assertTrue_, _assertFalse_, _assertNull_ or _assertNotNull_ instead (or _isNull_ etc. when using Fest). Using them with assertions unrelated to equality (such as _assertNull_) is most likely a bug.
|
|
|
|
|
|
Supported frameworks:
|
|
|
|
* JUnit3
|
|
* JUnit4
|
|
* JUnit5
|
|
* Fest assert
|
|
|
|
== Noncompliant Code Example
|
|
|
|
[source,java]
|
|
----
|
|
Assert.assertTrue(true); // Noncompliant
|
|
assertThat(null).isNull(); // Noncompliant
|
|
|
|
assertEquals(true, something()); // Noncompliant
|
|
assertNotEquals(null, something()); // Noncompliant
|
|
----
|
|
|
|
== Compliant Solution
|
|
|
|
[source,java]
|
|
----
|
|
assertTrue(something());
|
|
assertNotNull(something());
|
|
----
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
endif::env-github,rspecator-view[]
|