rspec/rules/S3415/comments-and-links.adoc

18 lines
744 B
Plaintext

=== on 24 Nov 2015, 15:41:14 Tamas Vajk wrote:
\[~ann.campbell.2] LGTM
=== on 24 Nov 2015, 16:17:08 Freddy Mallet wrote:
Hi [~ann.campbell.2], I would make this rule also targeting Java and would associate the tag 'java-top' to it. Thanks
=== on 24 Nov 2015, 21:23:40 Ann Campbell wrote:
Java targeted & java-top added [~freddy.mallet].
CC [~nicolas.peru]
=== on 25 Nov 2015, 10:50:59 Nicolas Peru wrote:
\[~ann.campbell.2] No problem for java and java-top but this would need a dedicated example for java. And, IMO, a clear definition of what is a "hardcoded" value : constant ? literal ? both ?
=== on 30 Nov 2015, 17:04:55 Ann Campbell wrote:
\[~nicolas.peru] I'd start with literals and locally-defined (class or method level) vars.