46 lines
1.4 KiB
Plaintext
46 lines
1.4 KiB
Plaintext
If you go to the trouble of importing a symbol statically, then you should make use of it, and you should do so consistently. Similarly, there's no reason to both import a class and then refer to it in code by its fully-qualified name. Otherwise, maintainers could be confused by the difference between qualified and unqualified references.
|
|
|
|
|
|
== Noncompliant Code Example
|
|
|
|
----
|
|
import java.util.*;
|
|
import java.math.BigInteger;
|
|
import static java.lang.String.format;
|
|
//...
|
|
|
|
String s1 = format("%cello %cellow", 'h','f'); // Compliant
|
|
String s2 = String.format("%cello %cellow", 'm','y'); // Noncompliant; is this a different format function than on the previous line?
|
|
|
|
java.util.List<String> list = new java.util.ArrayList<String>(); // Noncompliant; both classes included in java.util.* import
|
|
|
|
java.math.BigInteger myBigI = BigInteger.ZERO; // Noncompliant. This mixed usage is particularly confusing
|
|
----
|
|
|
|
|
|
== Compliant Solution
|
|
|
|
----
|
|
import java.util.*;
|
|
import java.math.BigInteger;
|
|
import static java.lang.String.format;
|
|
//...
|
|
|
|
String s1 = format("%cello %cellow", 'h','f');
|
|
String s2 = format("%cello %cellow", 'm','y');
|
|
|
|
List<String> list = new ArrayList<String>();
|
|
|
|
BigInteger myBigI = BigInteger.ZERO;
|
|
----
|
|
|
|
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::comments-and-links.adoc[]
|
|
endif::env-github,rspecator-view[]
|