rspec/rules/S1821/php/rule.adoc
2021-06-02 20:44:38 +02:00

44 lines
916 B
Plaintext

Nested ``++switch++`` structures are difficult to understand because you can easily confuse the cases of an inner ``++switch++`` as belonging to an outer statement. Therefore nested ``++switch++`` statements should be avoided.
Specifically, you should structure your code to avoid the need for nested ``++switch++`` statements, but if you cannot, then consider moving the inner ``++switch++`` to another function.
== Noncompliant Code Example
----
switch($a) {
case "foo":
switch($b) { // Noncompliant
case "bar":
doSomething();
break;
}
break;
}
----
== Compliant Solution
----
function handleFoo($foo) {
switch($foo) {
case "bar":
doSomething();
break;
}
}
switch($a) {
case "foo":
handleFoo($b);
break;
}
----
ifdef::rspecator-view[]
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::rspecator-view[]