27 lines
1.2 KiB
Plaintext
27 lines
1.2 KiB
Plaintext
=== Relates: RSPEC-1201
|
|
|
|
=== On 2015-05-22T09:54:56Z Tamas Vajk Wrote:
|
|
LGTM
|
|
|
|
=== On 2015-06-09T09:05:39Z Tamas Vajk Wrote:
|
|
\[~ann.campbell.2] I've changed all occurrences of "override" to "implement". I think it is better this way.
|
|
|
|
=== On 2015-06-09T13:46:11Z Ann Campbell Wrote:
|
|
okay, thanks [~tamas.vajk]
|
|
|
|
=== On 2015-06-18T11:41:33Z Tamas Vajk Wrote:
|
|
\[~ann.campbell.2] I've added an exception. This is a usual pattern in C#. You can read about it here: \https://msdn.microsoft.com/en-us/library/b1yfkh5e(v=vs.110).aspx
|
|
|
|
=== On 2015-06-18T12:00:49Z Ann Campbell Wrote:
|
|
okay [~tamas.vajk]
|
|
|
|
=== On 2015-08-04T18:14:10Z Ann Campbell Wrote:
|
|
\[~tamas.vajk] I've just mapped this to FxCop's ImplementIDisposableCorrectly, but I believe that rule is broader than this one.
|
|
|
|
=== On 2015-08-05T13:23:50Z Tamas Vajk Wrote:
|
|
\[~ann.campbell.2] Yes, it seems to me too that it is doing more. I'm not sure if we would want to add more disposable rules, or cover all the cases of this FxCop rule in this RSPEC.
|
|
|
|
=== On 2019-11-20T10:31:27Z Costin Zaharia Wrote:
|
|
We should add an exception in this rule for https://docs.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-8#disposable-ref-structs[disposable ref structs] introduced in C# 8.
|
|
|