33 lines
642 B
Plaintext
33 lines
642 B
Plaintext
Perhaps counter-intuitively, a ``++compareTo++`` method is _expected_ to throw a ``++NullPointerException++`` if passed a null argument, and a ``++ClassCastException++`` if the argument is of the wrong type. So there's no need to null-test or type-test the argument.
|
|
|
|
|
|
== Noncompliant Code Example
|
|
|
|
----
|
|
public int compareTo(Object obj) {
|
|
|
|
if (obj == null) { // Noncompliant
|
|
return -1;
|
|
}
|
|
if (! obj instanceof MyClass.class) { // Noncompliant
|
|
return -1;
|
|
}
|
|
|
|
MyObject myObj = (MyObject) obj;
|
|
// ...
|
|
}
|
|
----
|
|
|
|
|
|
== Compliant Solution
|
|
|
|
----
|
|
public int compareTo(Object obj) {
|
|
|
|
MyObject myObj = (MyObject) obj;
|
|
// ...
|
|
}
|
|
----
|
|
|
|
|