rspec/rules/S2243/abap/rule.adoc
Fred Tingaud 16f6c0aecf
Inline adoc when include has no additional value (#1940)
Inline adoc files when they are included exactly once.

Also fix language tags because this inlining gives us better information
on what language the code is written in.
2023-05-25 14:18:12 +02:00

42 lines
728 B
Plaintext

== Why is this an issue?
``++SELECT++`` with ``++JOIN++`` always performs better than nested selects.
=== Noncompliant code example
[source,abap]
----
SELECT * FROM SPFL INTO SPFLI_WA.
SELECT * FROM SFLOGHT INTO SFLIGHT_WA
WHERE CARRID = SPFLI_WA-CARRID
AND CONNID = SPFLIGHT_WA_CONNID.
ENDSELECT.
ENDSELECT.
----
=== Compliant solution
[source,abap]
----
SELECT * INTO WA
FROM SPFLI AS P INNER JOIN SFLIGHT AS F
ON P~CARRID = F~CARRID AND
P~CONNID = F~CONNID.
END-SELECT.
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Remove the nested "SELECT" statements by using the "JOIN" clause
endif::env-github,rspecator-view[]