rspec/rules/S1126/java/rule.adoc
2021-01-27 13:42:22 +01:00

31 lines
634 B
Plaintext

Return of boolean literal statements wrapped into ``++if-then-else++`` ones should be simplified.
Similarly, method invocations wrapped into ``++if-then-else++`` differing only from boolean literals should be simplified into a single invocation.
== Noncompliant Code Example
----
boolean foo(Object param) {
if (expression) { // Noncompliant
bar(param, true, "qix");
} else {
bar(param, false, "qix");
}
if (expression) { // Noncompliant
return true;
} else {
return false;
}
}
----
== Compliant Solution
----
boolean foo(Object param) {
bar(param, expression, "qix");
return expression;
}
----