23 lines
989 B
Plaintext
23 lines
989 B
Plaintext
Synchronization can be expensive in terms of time when multiple threads need to pass through the same bottleneck (method with ``\[MethodImpl(MethodImplOptions.Synchronized)\]``).
|
|
|
|
If you have a piece of code calling a method with ``\[MethodImpl(MethodImplOptions.Synchronized)\]`` attribute once, then it only has to wait its turn to pass through the bottleneck once. But call it in a loop, and your code has to get back in line for the bottleneck over and over.
|
|
|
|
Instead, it would be better to get into the bottleneck, and then do the looping. I.e. consider refactoring the code to perform the loop inside the method.
|
|
|
|
This rule raises an issue when a method with ``\[MethodImpl(MethodImplOptions.Synchronized)\]`` is called in a loop.
|
|
|
|
== Noncompliant Code Example
|
|
|
|
----
|
|
public void doSomething(int max) {
|
|
for (int i = 0; i < max; i++) {
|
|
doSynchronized(i); // Noncompliant
|
|
}
|
|
}
|
|
|
|
[MethodImpl(MethodImplOptions.Synchronized)]
|
|
public void doSynchronized(int val) {
|
|
// ...
|
|
}
|
|
----
|