rspec/rules/S3400/swift/rule.adoc
2020-12-23 14:59:06 +01:00

22 lines
670 B
Plaintext

There's no point in forcing the overhead of a function or method call for a function that always returns the same constant value. Even worse, the fact that a function call must be made will likely mislead developers who call the method thinking that something more is done. Declare a constant instead.
This rule raises an issue on functions that contain only one statement: the ``return`` of a constant value.
== Noncompliant Code Example
----
func getBestNumber() -> Int {
return 12 // Noncompliant
}
----
== Compliant Solution
----
let bestNumber = 12;
----
== Exceptions
Methods which are members of a class having a type inheritance clause are ignored.