51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
65 lines
1.1 KiB
Plaintext
65 lines
1.1 KiB
Plaintext
== Why is this an issue?
|
|
|
|
Jump statements (``++EXIT++``, ``++CONTINUE++``, ``++RETURN++``, ``++RAISE++``, and ``++RAISE_APPLICATION_ERROR++``), move control flow out of the current code block. So any statements that come after a jump are dead code.
|
|
|
|
|
|
This rule detects for statements that follow:
|
|
|
|
* ``++EXIT++`` without a ``++WHEN++``
|
|
* ``++CONTINUE++`` without a ``++WHEN++``
|
|
* ``++RETURN++``
|
|
* ``++RAISE++``
|
|
* ``++RAISE_APPLICATION_ERROR++``
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,sql]
|
|
----
|
|
SET SERVEROUTPUT ON
|
|
|
|
BEGIN
|
|
LOOP
|
|
DBMS_OUTPUT.PUT_LINE('This will be printed out');
|
|
EXIT;
|
|
|
|
DBMS_OUTPUT.PUT_LINE('This will NEVER be printed out'); -- Non-Compliant
|
|
END LOOP;
|
|
END;
|
|
/
|
|
----
|
|
|
|
=== Compliant solution
|
|
|
|
[source,sql]
|
|
----
|
|
SET SERVEROUTPUT ON
|
|
|
|
BEGIN
|
|
LOOP
|
|
DBMS_OUTPUT.PUT_LINE('This will be printed out');
|
|
EXIT;
|
|
END LOOP;
|
|
END;
|
|
/
|
|
----
|
|
|
|
include::../see.adoc[]
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
include::../highlighting.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|