51 lines
1.1 KiB
Plaintext
51 lines
1.1 KiB
Plaintext
== Why is this an issue?
|
|
|
|
A chain of ``++If++``/``++ElseIf++`` statements is evaluated from top to bottom. At most, only one branch will be executed: the first one with a condition that evaluates to ``++True++``.
|
|
|
|
|
|
Therefore, duplicating a condition automatically leads to dead code. Usually, this is due to a copy/paste error. At best, it's simply dead code and at worst, it's a bug that is likely to induce further bugs as the code is maintained, and obviously it could lead to unexpected behavior.
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,vbnet]
|
|
----
|
|
If param = 1 Then
|
|
OpenWindow()
|
|
ElseIf param = 2 Then
|
|
CloseWindow()
|
|
ElseIf param = 1 Then ' Noncompliant
|
|
MoveWindowToTheBackground()
|
|
End If
|
|
----
|
|
|
|
=== Compliant solution
|
|
|
|
[source,vbnet]
|
|
----
|
|
If param = 1 Then
|
|
OpenWindow()
|
|
ElseIf param = 2 Then
|
|
CloseWindow()
|
|
ElseIf param = 3 Then
|
|
MoveWindowToTheBackground()
|
|
End If
|
|
----
|
|
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
include::../highlighting.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
endif::env-github,rspecator-view[]
|