39 lines
778 B
Plaintext
39 lines
778 B
Plaintext
== Why is this an issue?
|
|
|
|
There's no need to null-test a variable before an ``++instanceof++`` test because ``++instanceof++`` tests for ``++null++``. Similarly, there's no need to null-test a variable before dereferencing _some other_ object.
|
|
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,java]
|
|
----
|
|
if (myVar != null && myVar instanceof MyClass) { // Noncompliant
|
|
// ...
|
|
} else if (myVar != null && myOtherVar.equals(myVar) { // Noncompliant
|
|
// ...
|
|
}
|
|
----
|
|
|
|
|
|
=== Compliant solution
|
|
|
|
[source,java]
|
|
----
|
|
if (myVar instanceof MyClass) {
|
|
// ...
|
|
} else if (myVar != null && myVar.equals(myOtherVar) {
|
|
// ...
|
|
}
|
|
----
|
|
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::message.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|