62 lines
980 B
Plaintext
62 lines
980 B
Plaintext
== Why is this an issue?
|
|
|
|
A ``++GOTO++`` statement is an unstructured change in the control flow. They should be avoided and replaced by structured constructs.
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,sql]
|
|
----
|
|
SET SERVEROUTPUT ON
|
|
|
|
DECLARE
|
|
i PLS_INTEGER := 42;
|
|
BEGIN
|
|
IF i < 0 THEN
|
|
GOTO negative; -- Noncompliant
|
|
END IF;
|
|
|
|
DBMS_OUTPUT.PUT_LINE('positive');
|
|
goto cleanup; -- Noncompliant
|
|
|
|
<<negative>>
|
|
DBMS_OUTPUT.PUT_LINE('negative!');
|
|
|
|
<<cleanup>>
|
|
NULL;
|
|
END;
|
|
/
|
|
----
|
|
|
|
=== Compliant solution
|
|
|
|
[source,sql]
|
|
----
|
|
SET SERVEROUTPUT ON
|
|
|
|
DECLARE
|
|
i PLS_INTEGER := 42;
|
|
BEGIN
|
|
IF i < 0 THEN
|
|
DBMS_OUTPUT.PUT_LINE('negative!'); -- Compliant
|
|
ELSE
|
|
DBMS_OUTPUT.PUT_LINE('positive');
|
|
END IF;
|
|
END;
|
|
/
|
|
----
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
endif::env-github,rspecator-view[]
|