8209548e54
Improvement identified in #2790. Add a prefix to the diff-id when it is used multiple times in different "how to fix it in XYZ" sections to avoid ambiguity and pedantically follow the spec: > A single and unique diff-id should be used only once for each type of code example as shown in the description of a rule. Obvious typos around `diff-type` were fixed. An obvious extra use of diff blocks was removed.
38 lines
933 B
Plaintext
38 lines
933 B
Plaintext
== How to fix it in OpenSSL
|
|
|
|
=== Code examples
|
|
|
|
include::../../common/fix/code-rationale.adoc[]
|
|
|
|
Certificate validation is not enabled by default and has to be explicitly
|
|
enabled through `set_verify`.
|
|
|
|
==== Noncompliant code example
|
|
|
|
[source,python,diff-id=1,diff-type=noncompliant]
|
|
----
|
|
from OpenSSL import SSL
|
|
|
|
ctx1 = SSL.Context(SSL.TLSv1_2_METHOD) # Noncompliant
|
|
|
|
ctx2 = SSL.Context(SSL.TLSv1_2_METHOD)
|
|
ctx2.set_verify(SSL.VERIFY_NONE, verify_callback) # Noncompliant
|
|
----
|
|
|
|
==== Compliant solution
|
|
|
|
[source,python,diff-id=1,diff-type=compliant]
|
|
----
|
|
from OpenSSL import SSL
|
|
|
|
ctx = SSL.Context(SSL.TLSv1_2_METHOD)
|
|
ctx.set_verify(SSL.VERIFY_PEER, verify_callback)
|
|
ctx.set_verify(SSL.VERIFY_PEER | SSL.VERIFY_FAIL_IF_NO_PEER_CERT, verify_callback)
|
|
ctx.set_verify(SSL.VERIFY_PEER | SSL.VERIFY_FAIL_IF_NO_PEER_CERT | SSL.VERIFY_CLIENT_ONCE, verify_callback)
|
|
----
|
|
|
|
=== How does this work?
|
|
|
|
include::../../common/fix/validation.adoc[]
|
|
|