51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
61 lines
1.3 KiB
Plaintext
61 lines
1.3 KiB
Plaintext
== Why is this an issue?
|
|
|
|
Nested ``++switch++`` structures are difficult to understand because you can easily confuse the ``++when++`` blocks of an inner ``++switch++`` as belonging to an outer statement. Therefore nested ``++switch++`` statements should be avoided.
|
|
|
|
|
|
Specifically, you should structure your code to avoid the need for nested ``++switch++`` statements, but if you cannot, then consider moving the inner ``++switch++`` to another function.
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,apex]
|
|
----
|
|
public void foo(Integer i, Integer j) {
|
|
switch on i {
|
|
when 1 {System.debug(' 1'); }
|
|
when 2 { System.debug(' 2'); }
|
|
when -3 {
|
|
switch on j { // Noncompliant
|
|
when 1 {System.debug(' 3');}
|
|
when else {System.debug(' 4');}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
----
|
|
|
|
=== Compliant solution
|
|
|
|
[source,apex]
|
|
----
|
|
public void foo(Integer i, Integer j) {
|
|
switch on i {
|
|
when 1 {System.debug(' 1'); }
|
|
when 2 { System.debug(' 2'); }
|
|
when -3 {bar(j);}
|
|
}
|
|
}
|
|
|
|
public void bar(Integer j) {
|
|
switch on j {
|
|
when 1 {System.debug(' 3');}
|
|
when else {System.debug(' 4');}
|
|
}
|
|
}
|
|
----
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::../message.adoc[]
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|