51369b610e
When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again.
71 lines
1.6 KiB
Plaintext
71 lines
1.6 KiB
Plaintext
== Why is this an issue?
|
|
|
|
Nested ``++Select Case++`` structures are difficult to understand because you can easily confuse the cases of an inner ``++Select Case++`` as belonging to an outer statement. Therefore nested ``++Select Case++`` statements should be avoided.
|
|
|
|
|
|
Specifically, you should structure your code to avoid the need for nested ``++Select Case++`` statements, but if you cannot, then consider moving the inner ``++Select Case++`` to another function.
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,vbnet]
|
|
----
|
|
Public Sub Foo(A As Integer, B As Integer)
|
|
Select Case A
|
|
Case 0
|
|
' ...
|
|
Case 1
|
|
Select Case B ' Noncompliant; nested Select Case
|
|
Case 2
|
|
' ...
|
|
Case 3
|
|
' ...
|
|
Case 4
|
|
' ...
|
|
Case Else
|
|
' ...
|
|
End Select
|
|
Case 2
|
|
' ...
|
|
Case Else
|
|
' ...
|
|
End Select
|
|
End Sub
|
|
----
|
|
|
|
=== Compliant solution
|
|
|
|
[source,vbnet]
|
|
----
|
|
Public Sub Foo(A As Integer, B As Integer)
|
|
Select Case A
|
|
Case 0
|
|
' ...
|
|
Case 1
|
|
HandleB(B)
|
|
Case 2
|
|
' ...
|
|
Case Else
|
|
' ...
|
|
End Select
|
|
End Sub
|
|
----
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
=== Message
|
|
|
|
Refactor the code to eliminate this nested 'Select Case'.
|
|
|
|
|
|
'''
|
|
== Comments And Links
|
|
(visible only on this page)
|
|
|
|
include::../comments-and-links.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|