rspec/rules/S4201/csharp/rule.adoc
Fred Tingaud 16f6c0aecf
Inline adoc when include has no additional value (#1940)
Inline adoc files when they are included exactly once.

Also fix language tags because this inlining gives us better information
on what language the code is written in.
2023-05-25 14:18:12 +02:00

36 lines
700 B
Plaintext

== Why is this an issue?
There's no need to null test in conjunction with an ``++is++`` test. ``++null++`` is not an instance of anything, so a null check is redundant.
=== Noncompliant code example
[source,csharp]
----
if (x != null && x is MyClass) { ... } // Noncompliant
if (x == null || !(x is MyClass)) { ... } // Noncompliant
----
=== Compliant solution
[source,csharp]
----
if (x is MyClass) { ... }
if (!(x is MyClass)) { ... }
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Remove this unnecessary null check; "is" returns false for nulls.
include::../highlighting.adoc[]
endif::env-github,rspecator-view[]