41 lines
939 B
Plaintext
41 lines
939 B
Plaintext
== Why is this an issue?
|
|
|
|
Java 7's try-with-resources structure automatically handles closing the resources that the ``++try++`` itself opens. Thus, adding an explicit ``++close()++`` call is redundant and potentially confusing.
|
|
|
|
|
|
=== Noncompliant code example
|
|
|
|
[source,java]
|
|
----
|
|
try (PrintWriter writer = new PrintWriter(process.getOutputStream())) {
|
|
String contents = file.contents();
|
|
writer.write(new Gson().toJson(new MyObject(contents)));
|
|
writer.flush();
|
|
writer.close(); // Noncompliant
|
|
}
|
|
----
|
|
|
|
|
|
=== Compliant solution
|
|
|
|
[source,java]
|
|
----
|
|
try (PrintWriter writer = new PrintWriter(process.getOutputStream())) {
|
|
String contents = file.contents();
|
|
writer.write(new Gson().toJson(new MyObject(contents)));
|
|
writer.flush();
|
|
}
|
|
----
|
|
|
|
ifdef::env-github,rspecator-view[]
|
|
|
|
'''
|
|
== Implementation Specification
|
|
(visible only on this page)
|
|
|
|
include::message.adoc[]
|
|
|
|
include::highlighting.adoc[]
|
|
|
|
endif::env-github,rspecator-view[]
|