rspec/rules/S5708/php/rule.adoc

63 lines
1.3 KiB
Plaintext
Raw Blame History

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

== Why is this an issue?
Instances of classes that do not derive from the "Throwable" interface cannot be used in a PHP "throw" statement. Thus, it does not make sense to try to catch such objects within a "try-catch" block.
Many built-in exceptions such as "Exception" and the SPL exception classes do implement the "Throwable" interface and can be extended when creating custom exceptions.
This rule raises an issue when the classes used to specify the type of objects to be caught in a "try-catch" block do not derive from "Throwable" .
=== Noncompliant code example
[source,php]
----
class NoThrowable {}
try {
foo();
} catch (NoThrowable $e) { // Noncompliant
}
----
=== Compliant solution
[source,php]
----
<?php
class SomeThrowable implements Throwable {
// Implementation of the Throwable methods
}
try {
foo();
} catch (SomeThrowable $e) { // Compliant
}
class SomeCustomException extends Exception {}
try {
foo();
} catch (SomeCustomException $e) { // Compliant
}{code}
 
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::message.adoc[]
include::highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]