rspec/rules/S3026/java/rule.adoc
2022-02-04 16:28:24 +00:00

37 lines
750 B
Plaintext

There's no need to null-test a variable before an ``++instanceof++`` test because ``++instanceof++`` tests for ``++null++``. Similarly, there's no need to null-test a variable before dereferencing _some other_ object.
== Noncompliant Code Example
[source,java]
----
if (myVar != null && myVar instanceof MyClass) { // Noncompliant
// ...
} else if (myVar != null && myOtherVar.equals(myVar) { // Noncompliant
// ...
}
----
== Compliant Solution
[source,java]
----
if (myVar instanceof MyClass) {
// ...
} else if (myVar != null && myVar.equals(myOtherVar) {
// ...
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::message.adoc[]
endif::env-github,rspecator-view[]